bpo-40016: re docstring: Clarify relationship of inline and argument flags#19078
Merged
Conversation
cool-RR
force-pushed
the
2020-03-19-re
branch
2 times, most recently
from
1c78a7d to
1117861
Compare
terryjreedy
requested changes
Mar 21, 2020
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Author
|
I didn't expect the Spanish Inquisition |
|
Nobody expects the Spanish Inquisition! @terryjreedy: please review the changes made to this pull request. |
cool-RR
changed the title
re module
terryjreedy
approved these changes
Mar 25, 2020
Member
There was a problem hiding this comment.
Looks good. The maxOS failure details were not available, so let us see what happens with retest. Otherwise, I think this ready to merge.
Added: The new Docs/Docs failure makes no sense. Git fetch failed and runner received a shutdown signal. Failed again on re-run. This patch does not touch the regular doc. Even if this text includes blurbs, the change since the previous run should not cause a failure.
Member
|
@vstinner @pablogsal The Docs/Docs test is failing tonight with a git fetch failure. The only 'doc change' is the news item. Do either of you know what is going on? May I merge anyway? |
Contributor
|
Thanks @cool-RR for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
@terryjreedy: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2020
…flags (pythonGH-19078) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <ram@rachum.com>
|
GH-19161 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 25, 2020
…flags (pythonGH-19078) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 89a2209) Co-authored-by: Ram Rachum <ram@rachum.com>
|
GH-19162 is a backport of this pull request to the 3.7 branch. |
Member
|
The Travis checks passed, but this was not reported back here. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40016